Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding weighted moving average #677

Merged
merged 3 commits into from
May 8, 2024
Merged

Adding weighted moving average #677

merged 3 commits into from
May 8, 2024

Conversation

AkshatGiri
Copy link
Contributor

@AkshatGiri AkshatGiri commented May 7, 2024

Weighted Moving Average Checklist

  • Indicator is documented and implemented by extending BigIndicatorSeries
  • A "faster" version of this indicator is implemented by extending NumberIndicatorSeries
  • Tests for getResult are present
  • Tests for highest and lowest result caching are present (if not already existent for base class)
  • Tests for error handling are present (if not already existent for base class)
  • Indicators (standard & faster version) are exposed in src/index.ts
  • Indicators (standard & faster version) are added to startBenchmark.ts
  • Indicator is listed in README.md

Feature requested in discussion - #674

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ebb6c01) to head (56d88ce).
Report is 59 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #677    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           36        37     +1     
  Lines         2290      2538   +248     
  Branches       248       304    +56     
==========================================
+ Hits          2290      2538   +248     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennycode bennycode merged commit 87bb0fb into bennycode:main May 8, 2024
5 checks passed
@bennycode
Copy link
Owner

Thank you very much for your contribution @AkshatGiri! 👏

I verified that the output from WMA & WSMA are different and I also fixed a little issue with the caching of the lowest & highest result: #684

You can use WMA now in [email protected].

Let me know how it goes! 💫

Best,
Benny

@AkshatGiri
Copy link
Contributor Author

Thanks for the quick merge @bennycode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants