Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller-tools to version v0.15.0, fix compilation failure in main func #16

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mikebaum
Copy link
Contributor

This PR is a proposed fix for issue: #15.

Changes:

  • Updated controller-tools to v0.15.0 which contains the upstream fix for controller-gen no longer working with go version 1.22
  • Updated the controller manager Options to properly set the Metrics bind address and WebHook Server port since the Options have changed.

@charlie-haley
Copy link
Member

Thanks for the PR @mikebaum!

@charlie-haley charlie-haley merged commit 40d0d03 into benthosdev:main Apr 24, 2024
1 of 3 checks passed
@mikebaum
Copy link
Contributor Author

Thanks for the PR @mikebaum!

@charlie-haley my pleasure and thank you for starting this project. Looking forward to evaluating benthos-captain for our uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants