Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env property to pipeline API #20

Merged
merged 1 commit into from
May 6, 2024

Conversation

mikebaum
Copy link
Contributor

@mikebaum mikebaum commented May 6, 2024

This PR adds the 'env' property to the pipeline API which corresponds to the Kubernetes DeploymentSpec property template.spec.container.env. This is a continuation of the work to satisfy Issue #18

Copy link
Member

@charlie-haley charlie-haley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR @mikebaum. LGTM!

@charlie-haley charlie-haley merged commit 4ac900c into benthosdev:main May 6, 2024
3 checks passed
@charlie-haley charlie-haley mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants