Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support light/dark background branding #298

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed marked this pull request as ready for review December 11, 2024 21:45
@davidlougheed davidlougheed requested a review from gsfk December 11, 2024 21:48
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with bento_public to see if I could actually reach the logos. Works as expected in prod mode, but faceplants on dev. Current main in dev mode gives this:

[webpack-dev-middleware] [Error: EROFS: read-only file system, open '/bento-public/dist/public/assets/branding.lightbg.png']

a different branch (i18n/manage-charts) give this instead:

[webpack-dev-middleware] [Error: EBUSY: resource busy or locked, unlink '/bento-public/dist/public/assets/branding.lightbg.png']

@davidlougheed
Copy link
Member Author

is public pulled to latest for this?

@gsfk gsfk self-requested a review December 12, 2024 18:16
@davidlougheed davidlougheed merged commit 7560722 into releases/v18 Dec 12, 2024
2 checks passed
@davidlougheed davidlougheed deleted the feat/light-dark-logo branch December 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants