refact: rename fetchDatasetSummaries... action

bento-platform · Oct 29, 2024 · ddfea7d · ddfea7d
1 parent 1ae658a
commit ddfea7d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/components/datasets/Dataset.js b/src/components/datasets/Dataset.js
@@ -13,7 +13,7 @@ import {
   deleteDatasetLinkedFieldSetIfPossible,
 } from "@/modules/metadata/actions";
 
-import { fetchDatasetDataTypesIfPossible, fetchDatasetSummariesIfPossible } from "@/modules/datasets/actions";
+import { fetchDatasetDataTypesIfPossible, fetchDatasetSummariesIfNeeded } from "@/modules/datasets/actions";
 
 import { INITIAL_DATA_USE_VALUE } from "@/duo";
 import { simpleDeepCopy, nop } from "@/utils/misc";
@@ -335,7 +335,7 @@ const mapDispatchToProps = (dispatch, ownProps) => ({
   deleteProjectDataset: (dataset) => dispatch(deleteProjectDatasetIfPossible(ownProps.project, dataset)),
   deleteLinkedFieldSet: (dataset, linkedFieldSet, linkedFieldSetIndex) =>
     dispatch(deleteDatasetLinkedFieldSetIfPossible(dataset, linkedFieldSet, linkedFieldSetIndex)),
-  fetchDatasetSummary: (datasetId) => dispatch(fetchDatasetSummariesIfPossible(datasetId)),
+  fetchDatasetSummary: (datasetId) => dispatch(fetchDatasetSummariesIfNeeded(datasetId)),
   fetchDatasetDataTypesSummary: (datasetId) => dispatch(fetchDatasetDataTypesIfPossible(datasetId)),
 });
 

diff --git a/src/modules/datasets/actions.js b/src/modules/datasets/actions.js
@@ -39,7 +39,7 @@ const fetchServiceDatasetSummary = networkAction((serviceInfo, datasetID) => ({
   url: `${serviceInfo.url}/datasets/${datasetID}/summary`,
 }));
 
-export const fetchDatasetSummariesIfPossible = (datasetID) => async (dispatch, getState) => {
+export const fetchDatasetSummariesIfNeeded = (datasetID) => async (dispatch, getState) => {
   const existingSummaryState = getState().datasetSummaries.itemsByID[datasetID] ?? {};
   if (existingSummaryState.isFetching || (!existingSummaryState.isInvalid && existingSummaryState.hasAttempted)) return;
   dispatch(beginFlow(FETCHING_DATASET_SUMMARIES, { datasetID }));

diff --git a/src/modules/datasets/hooks.js b/src/modules/datasets/hooks.js
@@ -4,7 +4,7 @@ import { useAppDispatch, useAppSelector } from "@/store";
 import {
   fetchDatasetDataTypesIfPossible,
   fetchDatasetsDataTypes,
-  fetchDatasetSummariesIfPossible,
+  fetchDatasetSummariesIfNeeded,
 } from "@/modules/datasets/actions";
 
 export const useDatasetDataTypes = () => {
@@ -50,7 +50,7 @@ export const useDatasetSummariesByID = (datasetId) => {
    */
   const dispatch = useAppDispatch();
   useEffect(() => {
-    dispatch(fetchDatasetSummariesIfPossible(datasetId)).catch(console.error);
+    dispatch(fetchDatasetSummariesIfNeeded(datasetId)).catch(console.error);
   }, [dispatch, datasetId]);
   return useAppSelector((state) => state.datasetSummaries.itemsByID[datasetId]);
 };