smoother handling for empty pie chart categories

bento-platform · Apr 20, 2022 · e91ca3f · e91ca3f
1 parent 431e48e
commit e91ca3f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/utils/mapNameValueFields.js b/src/utils/mapNameValueFields.js
@@ -13,14 +13,14 @@ export const mapNameValueFields = (data, otherThreshold) => {
     const other = { name: "Other", value: 0, skipAutoquery: true };
 
     Object.entries(data).forEach(([key, val]) => {
-        const categoryNotEmpty = val > 0;
+        if (val === 0) {
+            return;   //continue
+        }
         const categoryBelowThreshold = val / sumOfAllValues < otherThreshold;
-        if (multipleCategoriesBelowThreshold && categoryNotEmpty && categoryBelowThreshold) {
+        if (multipleCategoriesBelowThreshold && categoryBelowThreshold) {
             other.value += val;
         } else {
-            if (categoryNotEmpty) {
-                results.push({ name: key, value: val });
-            }
+            results.push({ name: key, value: val });
         }
     });