Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): search row expansion with details #474

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed requested a review from gsfk December 18, 2024 17:51
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually took me a while to figure out what the functionality was, seems to work as intended. I can't tell if I'd ever use it in lieu of clicking the entry.

ExperimentsTable.js gives me a React warning, although it seems like it the fault of the existing code. Specifically this line:
render: (experimentId, record) => <ExperimentRender experimentId={experimentId} {...record} />

gives this warning about spread:

ExperimentsTable.js:73 Warning: A props object containing a "key" prop is being spread into JSX. React keys must be passed directly to JSX without using spread.

@davidlougheed
Copy link
Member Author

most of the point of this is to make experiment results files accessible in fewer clicks; the other expansions I just added because it was easy to do so. I'll look into fixing the key error...

@davidlougheed davidlougheed requested a review from gsfk December 18, 2024 20:31
@davidlougheed davidlougheed merged commit a136407 into master Dec 18, 2024
3 checks passed
@davidlougheed davidlougheed deleted the feat/explorer/search-row-expand branch December 18, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants