chores(engine-primitives): nit #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Oct 14, 2024
| @@ -63,18 +63,16 @@ type PayloadAttributes[ | |||
| ParentBeaconBlockRoot common.Root `json:"parentBeaconBlockRoot"` | |||
| } | |||
|
|
|||
| // NewPayloadAttributes creates a new PayloadAttributes. | |||
| func NewPayloadAttributes[ | |||
There was a problem hiding this comment.
This is not really needed and used only in tests. The New method is required by a few interfaces
abi87
commented
Oct 14, 2024
|
|
||
| func TestPayloadAttributes(t *testing.T) { |
There was a problem hiding this comment.
consolidated tests into a single, table driven test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update-mockery-v2-46-3 #2068 +/- ##
==========================================================
- Coverage 22.24% 22.20% -0.04%
==========================================================
Files 356 352 -4
Lines 16034 15976 -58
Branches 12 0 -12
==========================================================
- Hits 3566 3547 -19
+ Misses 12316 12277 -39
Partials 152 152
|
itsdevbear
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped constructor used in unit tests only. Marginally improved test coverage. Consolidated unit tests into table driven unit test.