Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of context.Background() #2376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

fridrik01
Copy link
Contributor

@fridrik01 fridrik01 commented Jan 19, 2025

We should only use this in top-level code like in main and tests and such as context.Background is not cancellable

@fridrik01 fridrik01 self-assigned this Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (2afec05) to head (5f57ce8).

Files with missing lines Patch % Lines
beacon/blockchain/process_proposal.go 0.00% 2 Missing ⚠️
da/blob/processor.go 0.00% 1 Missing ⚠️
da/blob/verifier.go 0.00% 1 Missing ⚠️
state-transition/core/state_processor_payload.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
- Coverage   27.12%   27.11%   -0.01%     
==========================================
  Files         351      351              
  Lines       15523    15524       +1     
  Branches       20       20              
==========================================
  Hits         4210     4210              
- Misses      11110    11111       +1     
  Partials      203      203              
Files with missing lines Coverage Δ
da/blob/processor.go 0.00% <0.00%> (ø)
da/blob/verifier.go 0.00% <0.00%> (ø)
state-transition/core/state_processor_payload.go 0.00% <0.00%> (ø)
beacon/blockchain/process_proposal.go 0.00% <0.00%> (ø)

@fridrik01 fridrik01 changed the title Potential case where we can deadline Potential case where we can hand during SIGTERM Jan 19, 2025
@fridrik01 fridrik01 force-pushed the fix-sigterm-hangs branch 2 times, most recently from 8eaf2eb to 7c4d708 Compare January 19, 2025 22:07
@fridrik01 fridrik01 changed the title Potential case where we can hand during SIGTERM Remove uses of context.Background() Jan 19, 2025
@fridrik01 fridrik01 marked this pull request as ready for review January 19, 2025 22:08
@fridrik01 fridrik01 requested a review from a team as a code owner January 19, 2025 22:08
@abi87 abi87 force-pushed the fix-sigterm-hangs branch from 7c4d708 to 04166e7 Compare January 19, 2025 23:49
@fridrik01 fridrik01 force-pushed the fix-sigterm-hangs branch 2 times, most recently from c7840da to 93ff22d Compare January 20, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants