Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lower test iterations to address slow sidecar test #2385

Closed
wants to merge 1 commit into from

Conversation

fridrik01
Copy link
Contributor

The test-unit-cover test takes over 9minutes to run on our CI which is double the next longest CI task (test-e2e). This lowers the maximum iterations in the blob sidecar test so it should take approximately the same time as the test-e2e

@fridrik01 fridrik01 self-assigned this Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.57%. Comparing base (cd3c709) to head (dbef32c).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2385   +/-   ##
=======================================
  Coverage   31.57%   31.57%           
=======================================
  Files         348      348           
  Lines       15529    15529           
  Branches       20       20           
=======================================
  Hits         4903     4903           
  Misses      10282    10282           
  Partials      344      344           

@fridrik01 fridrik01 marked this pull request as ready for review January 20, 2025 21:12
@fridrik01 fridrik01 requested a review from a team as a code owner January 20, 2025 21:12
@fridrik01 fridrik01 force-pushed the address-slow-test-unit-cover branch from e8709a4 to 9192608 Compare January 28, 2025 20:07
@fridrik01 fridrik01 force-pushed the address-slow-test-unit-cover branch from 9192608 to dbef32c Compare January 31, 2025 12:36
@fridrik01
Copy link
Contributor Author

was fixed in #2459

@fridrik01 fridrik01 closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant