chore(genesis deposit) : Change in local network setup with single node

[nidhi-singh02]

Using cli command for setting deposit contract storage slot values and using the correct genesis files(the one being modified by the cli command)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.12%. Comparing base (2afec05) to head (893395f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2402   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files         351      351           
  Lines       15523    15523           
  Branches       20       20           
=======================================
  Hits         4210     4210           
  Misses      11110    11110           
  Partials      203      203           

[abi87]

@nidhi-singh02 why do we execute both commands? I mean for both nethermind nodes and non-nethermind ones

[nidhi-singh02]

As we want to modify the deposit contract storage slot values for both the genesis files - for nethermind and for others. @calbera I hope my understanding is correct.

[calbera]

Yeah the idea here is set both eth genesis files so that in case the user wants to start nethermind as the EL, its genesis file is also ready

[abi87]

I am not sure this change is complete.
Shouldn't we make sure that also make start-<EL> pick the right genesis file, as it was modified by the set-deposit-storage command?

[nidhi-singh02]

I am not sure this change is complete. Shouldn't we make sure that also make start-<EL> pick the right genesis file, as it was modified by the set-deposit-storage command?

Yes, you are right, we are ensuring that as we changed the genesis path values as below -

ETH_GENESIS_PATH = ${HOMEDIR}/eth-genesis.json
NETHER_ETH_GENESIS_PATH = ${HOMEDIR}/eth-nether-genesis.json

[calbera]

2 things:

• would add the readme note from internal
• would ensure all EL clients startup correctly with the correct deposit contract state

[nidhi-singh02]

I validated by running genesis sanity checks that we have for all the EL clients - geth, reth, erigon, besu and nethermind.
Facing issues in spinning up a beacond-ethereumjs network, tried on main branch as well - same issue. I have opened up an issue to track it #2408

I spent some time tweaking few parameters for ethereumjs, it needs more time to dig into. Fixing something wrong that I see with ethereumjs data directory path in this PR.

[calbera]

LGTM. tested that the deposit contract queries correctly on all ELs, even ethereumjs. Regarding ethereumjs not starting up correctly, that is also the case on main, so unrelated to this PR. will keep issue #2408 open