wip: engine api errors TODOs #2410
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
==========================================
- Coverage 27.08% 21.17% -5.91%
==========================================
Files 351 3 -348
Lines 15543 85 -15458
Branches 20 20
==========================================
- Hits 4210 18 -4192
+ Misses 11130 66 -11064
+ Partials 203 1 -202 |
calbera
commented
Jan 25, 2025
execution/client/helpers.go
Outdated
Comment on lines
86
to
88
| // NewPayload -- | ||
| // FCU -- | ||
| return nil, engineerrors.ErrUnknownPayloadStatus |
There was a problem hiding this comment.
in this case, probably want to return REJECT ProcessProposal (as is) and also error in FinalizeBlock
cc @rezbera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.