Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Testing Framework with Injected CometBFT #2411

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rezbera
Copy link
Contributor

@rezbera rezbera commented Jan 25, 2025

No description provided.

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.17%. Comparing base (1aff871) to head (ed588b3).

❗ There is a different number of reports uploaded between BASE (1aff871) and HEAD (ed588b3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1aff871) HEAD (ed588b3)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2411       +/-   ##
===========================================
- Coverage   32.36%   21.17%   -11.20%     
===========================================
  Files         350        3      -347     
  Lines       15592       85    -15507     
  Branches       20       20               
===========================================
- Hits         5047       18     -5029     
+ Misses      10182       66    -10116     
+ Partials      363        1      -362     

see 347 files with indirect coverage changes

@rezbera rezbera force-pushed the testing-mocked-comet branch from b95fa28 to 1b81a02 Compare January 30, 2025 16:20
execution/client/client.go Outdated Show resolved Hide resolved

import "github.com/berachain/beacon-kit/errors"

var (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unusued - cleanup

@@ -61,19 +61,6 @@ type StartCmdOptions[
AddFlags func(cmd *cobra.Command)
}

// StartCmd runs the service passed in, either stand-alone or in-process with
// CometBFT.
func StartCmd[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unusued - cleanup


// Fork is a type alias for the fork.
Fork = types.Fork

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unusued - cleanup

config/config.go Outdated
@@ -86,16 +86,6 @@ func (c Config) Template() string {
return template.TomlTemplate
}

// MustReadConfigFromAppOpts reads the configuration options from the given
// application options.
func MustReadConfigFromAppOpts(opts AppOptions) *Config {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unusued - cleanup

@rezbera rezbera force-pushed the testing-mocked-comet branch from 751fc88 to 813326c Compare January 30, 2025 23:25
@rezbera rezbera force-pushed the testing-mocked-comet branch 3 times, most recently from 71eeef7 to d6d5f95 Compare January 31, 2025 19:52
@rezbera rezbera changed the title WIP: Testing Framework with Mocked CometBFT WIP: Testing Framework with Injected CometBFT Jan 31, 2025
@rezbera rezbera force-pushed the testing-mocked-comet branch from 0a13b11 to 40c5f1b Compare February 1, 2025 21:28
@rezbera rezbera force-pushed the testing-mocked-comet branch from 94b8173 to 81bfa91 Compare February 3, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant