fix(initchain): Enforce stricter handling on InitChain Requests #2413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code for handling
[]ValidatorUpdate
was copied from CosmosSDK. In our case, theValidatorUpdate
list is ALWAYS expected to be 0 in initChain as we derive the validator set from the deposits directly in InitChain, which is the source of truth.Therefore, we can remove the additional handling if the
len([]ValidatorUpdate) > 0
and simply enforce that it is always zero length, reducing confusion around its purpose