feat: goto definition #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillLillis
force-pushed
the
goto_definition
branch
4 times, most recently
from
a9ee10f to
ac523d0
Compare
|
Not related to this PR but I believe we can replace the call to For example, something like https://github.com/WillLillis/asm-lsp/blob/3e948be81f0b751079b5330c5f6a2c101387315e/src/bin/main.rs#L203 |
WillLillis
force-pushed
the
goto_definition
branch
from
d039a9d to
cbcb455
Compare
WillLillis
force-pushed
the
goto_definition
branch
from
cbcb455 to
49aa20b
Compare
Clean up comments Replace use of get_word_from_file_params() in get_goto_def_resp() Use lsp_pos_of_point() Refactor get word logic into function
WillLillis
force-pushed
the
goto_definition
branch
from
49aa20b to
e15fd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds goto definition capabilities for labels, building off of the work from #36.
Completes one of the requests in #44