Justin's and My Changes #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will indicate what time the registry was last updated.
The README had references to plugin installation from berk's repository.
rake db:migrate wasn't working
I changed the references to me since Berk is, probably, no longer maintaining this gem.
Add vendor/bundle to .gitignore so we don't see it when we run git status.
I want to load acts_as_versioned as a gem. since that will externalize the dependency somewhat.
These are Geni specific and don't belong here.
We need to make sure we're running the correct ruby version.
These weren't working because they used an old require line
There were useless references.
I need to set the gem versions since I've locked the ruby version to 1.9.
Testing works. There are a lot of failures though.
The tests pass. I had to get the acts_as_versioned gem directly from github. This was the version I removed in an earlier commit.
I had to convert from rcov to simplecov.
Entering an invalid date caused the registry to raise an error which prevented our application from coming up. I now try to parse the date in three different formats, and if that fails I just return the string.
It looks like gems specified in Gemfile aren't included when you include the Gem in another project. So I copied the acts_as_versioned file from the gem into our lib directory.
There's something wonky with our config/registry.yml and I need some more details. I decided that adding a :verbose flag would be easier than rescuing the error, updating the messge and re-raising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justin updated the gemspec and version.
I fixed the tests, and added
Registry._last_updated_at