Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for failed object conversion #1

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

voneiden
Copy link
Contributor

The original cad_objs will just log an empty list. Assuming the original intent was to log cad_obj instead.

Noticed this while exploring voneiden/cq-cam/issues/23

As a side note, looks like adding support for AIS objects might be a bit involved. We got two visualization options in cq-cam, AIS based and Edge based. AIS was originally used because it allows connecting lines of different colours using AIS_MultipleConnectedInteractive. However I'd be willing to research a bit if the edge based visualization can be improved to make AIS visualization redundant.

@bernhard-42 bernhard-42 merged commit ba2e2b5 into bernhard-42:main Apr 27, 2023
@bernhard-42
Copy link
Owner

Thanks for fixing it!

I am not familiar with AIS (and ocp_tessellate is not using AIS).
What do you want to achieve from a user perspective?

@voneiden
Copy link
Contributor Author

Yeah no worries, I'll see what I can do. cq-cam allows generating CNC machining toolpaths on cadquery parts, so I'm using AIS to visualize the various generated paths. For example something like this

image

Besides getting better colour control, I have a faint memory that there may have been a performance benefit from using AIS, but I'll need to reinvestigate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants