Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Enrich UI data with new data from the API #100

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

ekelen
Copy link
Collaborator

@ekelen ekelen commented Apr 24, 2020

Feat(web): Enrich UI data with new data from the API.

To test: Check the Netlify preview, and see way less [TODO: Placeholder] stuff!

Related to #62

Add safe destructuring for HTTP response

Move HTTP request out of component

Split out HTTP functions; move style utils

Add commit hash, MR url, project URL

Separate files for Artifacts and parent Build

Add short build Id

Add time ago and remove unused css classes

Move out constants, fix dayjs plugins

Add [todo] to author

Add artifact ID (merge ID from build)

Add arrow SVG to download button

Remove unused imports

Add back in commit icon, no link if no commit url
@ekelen ekelen added the front label Apr 24, 2020
@ekelen ekelen requested a review from a team as a code owner April 24, 2020 19:04
@ekelen ekelen self-assigned this Apr 24, 2020
@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Apr 24, 2020
@ekelen ekelen changed the title WIP: Feat(web): Enrich UI data with new data from the API Feat(web): Enrich UI data with new data from the API Apr 24, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Apr 24, 2020
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@moul moul merged commit 8fc03c2 into master Apr 24, 2020
@moul moul deleted the feat/handle-new-api-data branch April 24, 2020 19:20
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet ✅ Approved Pull Request has been approved and can be merged labels Apr 24, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants