Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(front): remove CSS libs and evolve feed and header design #414

Merged
merged 6 commits into from
Nov 22, 2020
Merged

refactor(front): remove CSS libs and evolve feed and header design #414

merged 6 commits into from
Nov 22, 2020

Conversation

ekelen
Copy link
Collaborator

@ekelen ekelen commented Oct 31, 2020 •
edited
Loading

refactor:

  • remove CSS framework (workaround CSS was unreadable)
  • remove SASS (simply not needed)
  • remove (almost) all inline styles
  • move frontend theme elements from Theme context to CSS

design work:

  • visually demarcate builds in individual feed items
  • separate header info/action regions for clarity (meta/attribution info, filters, and actions)
  • move some small widgets around so that more info is available on small screens (especially author name)
  • unify modal and form styles
  • add some more font styles to distinguish info/link/tags etc more clearly

functionality extension:

  • pull to refresh finally working on mobile ? 🤞
  • filter by branch (click a branch name inside a feed item; it will save that branch as a filter for your session)
  • 'clear filters' action

fix:

build:

  • update golangci-lint

Closes #285
Maybe #326
Related to ##2

Signed-off-by: Elizabeth Kelen [email protected]

@ekelen ekelen self-assigned this Oct 31, 2020
@auto-add-label auto-add-label bot added the WIP label Oct 31, 2020
@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Oct 31, 2020
@ekelen ekelen force-pushed the refactor/remove-tabler-remove-sass branch 3 times, most recently from 04ad703 to d9ef998 Compare November 3, 2020 23:51
@ekelen ekelen force-pushed the refactor/remove-tabler-remove-sass branch 2 times, most recently from 55b40ed to 9181af6 Compare November 9, 2020 23:11
@ekelen ekelen force-pushed the refactor/remove-tabler-remove-sass branch from d1f67fe to 2c32a07 Compare November 19, 2020 22:26
@ekelen
refactor(front): refactor and adapt styles for current functionality
cc405b0 
remove sass and Tabler lib

remove inline styles and frontend color variables

create common css modules for reused styles

scale down sizing on smaller screens

add more themed CSS color variables where needed

revamp header style to visually separate concerns

add reset filter button to header

move feed item chevron toggle to enable author name display on all screen sizes

refactor icon utilities

rename build -> FeedItem etc

enable custom branch filter from feedItem body

replace owner icon with project icon (as in spec)

replace underline with special link color for text links

restore pull to refresh on mobile

add special osx icon to differentiate from iOS

add safe getter utils

replace octocat with gh + berd icons in header

unify modal styles

Signed-off-by: Elizabeth Kelen <[email protected]>
@ekelen ekelen force-pushed the refactor/remove-tabler-remove-sass branch from 2c32a07 to cc405b0 Compare November 19, 2020 23:13
@ekelen ekelen force-pushed the refactor/remove-tabler-remove-sass branch from 3e24918 to b19ea66 Compare November 22, 2020 01:39
@ekelen ekelen changed the title WIP: refactor(front): remove sass and css frameworks refactor(front): remove CSS libs and evolve feed and header design Nov 22, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Nov 22, 2020
@ekelen ekelen marked this pull request as ready for review November 22, 2020 01:50
@ekelen ekelen requested a review from moul as a code owner November 22, 2020 01:50
@ekelen ekelen merged commit 0641395 into master Nov 22, 2020
@ekelen ekelen deleted the refactor/remove-tabler-remove-sass branch November 22, 2020 02:00
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 22, 2020
@ekelen ekelen mentioned this pull request Nov 22, 2020
Closed
@github-actions
Copy link

🎉 This PR is included in version 2.98.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul Awaiting requested review from moul moul is a code owner

Assignees

@ekelen ekelen

Labels
front ✨ Merged Pull Request has been merged successfully refactor released WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ekelen