Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(web): Fix UI display on mobile and desktop #90

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

ekelen
Copy link
Collaborator

@ekelen ekelen commented Apr 22, 2020

Feature(web): Fix UI display on mobile (iOS 13.4 in Safari) and Desktop

It's not pixel-perfect, but everything should be visible and functional on iPhone or emulator.

Some of the ugly overflowing [TODO] text will be gone when this is synced with the new models.

To test: Get the Netlify preview; run it on iOS and in desktop browser.

Things done:

  • Fit header filters
  • Fit modal
    [ ] Filter modal can scroll sideways Not needed at the moment
  • Fit or remove logo - removed from mobile view for new
  • Fix overflowing and tall buttons/tags (Default web interface buttons overflowing on mobile #79 )
  • Fix build title size
  • Fix iOS background color below pagefold
  • Wrap or hide long branch names
  • Align some stuff

Closes #62 (🤞) and #79

@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Apr 22, 2020
@ekelen ekelen force-pushed the feature/mobile-first-styles branch 4 times, most recently from 3474626 to ff402e6 Compare April 23, 2020 19:53
Add breakpoint list

Fit header on mobile, TODO: background issues, cards

Fix background color theme issues in Safari

Card title size fixed

Header is tolerably responsive

Fix artifact tags

Fix tag cursor

Fix overwritten card title style

Card header okay

All card data visible on iOS

Remove unnecessary rules, end up adding morewq
@ekelen ekelen force-pushed the feature/mobile-first-styles branch from ff402e6 to 409c342 Compare April 23, 2020 20:05
@ekelen ekelen changed the title WIP: Feat(web): Mobile-friendly layout Feature(web): Fix UI display on mobile and desktop Apr 23, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Apr 23, 2020
@ekelen ekelen requested a review from clegirar April 23, 2020 20:11
@ekelen ekelen marked this pull request as ready for review April 23, 2020 20:14
@ekelen ekelen requested a review from a team as a code owner April 23, 2020 20:14
Copy link
Contributor

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 23, 2020
@ekelen ekelen merged commit a77de7a into master Apr 23, 2020
@ekelen ekelen deleted the feature/mobile-first-styles branch April 23, 2020 20:17
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Apr 23, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: Implement default view using design specs
2 participants