Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Add basic 32x32 favicon #98

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Feat(web): Add basic 32x32 favicon #98

merged 1 commit into from
Apr 24, 2020

Conversation

ekelen
Copy link
Collaborator

@ekelen ekelen commented Apr 24, 2020

This only adds standard browser favicon.

Is this sufficient for now @moul ? If not I will look later to configure webpack to load other icons into build folder.

Closes #94

@ekelen ekelen requested a review from moul April 24, 2020 14:36
@ekelen ekelen requested a review from a team as a code owner April 24, 2020 14:36
@ekelen ekelen self-assigned this Apr 24, 2020
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Apr 24, 2020
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Apr 24, 2020
@moul moul merged commit 08861e4 into master Apr 24, 2020
@moul moul deleted the feat/favicon branch April 24, 2020 14:40
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Apr 24, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add favicon
2 participants