[RFC] Adding subpod hetero #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichmond
reviewed
Jul 26, 2021
Comment on lines
+18
to
+31
| #(parameter addr_width_p = "inv" | ||
| ,parameter data_width_p = "inv" | ||
| ,parameter x_cord_width_p = "inv" | ||
| ,parameter y_cord_width_p = "inv" | ||
| // by default els_p=3 because credit-based interface has 2 cycle latency | ||
| // reducing fifo size below 3 may introduce bubble cycle(s) | ||
| ,parameter fifo_els_p = 3 | ||
| ,parameter fwd_width_lp = | ||
| `bsg_manycore_packet_width(addr_width_p,data_width_p,x_cord_width_p,y_cord_width_p) | ||
| ,parameter rev_width_lp = | ||
| `bsg_manycore_return_packet_width(x_cord_width_p,y_cord_width_p,data_width_p) | ||
| ,parameter manycore_link_width_lp = | ||
| `bsg_manycore_link_sif_width(addr_width_p,data_width_p,x_cord_width_p,y_cord_width_p) | ||
| ) |
There was a problem hiding this comment.
What's the policy for switching to the new parameter macros?
There was a problem hiding this comment.
Good question. None of the other manycore modules have switched, so I didn’t. But I’d be happy to make the change
dpetrisko
force-pushed
the
subpod_hetero
branch
from
a97a540 to
55a29bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bsg_manycore_subpod_hetero, a module to abstract external pod connections to the manycore. The idea is for this to be an easy way to add pods connected using the bigblade methodology. It provides a shell with bsg_tag to configure a clock+reset generator, coordinates, and SDR bringup.
There's a slight modification to the hetero socket which allows for multi-link connections. It also adds bsg_manycore_link_resp_credit_to_ready_and_handshake from the tapeout.
Planning on modifying the BP setup in the tapeout testbench to use this to validate, but looking for early feedback!