Refresh slide dimension settings after each resize #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bespoke-scale saves slide dimensions at initialization and refers to it through further process, it doesn't work well, if for some reason we changed slides size during the presentation.
I have such use case when using bespoke-notes plugin. It allows to optionally display notes aside of slide (then slide width becomes twice as long as initial one). Additionally it dispatches
resize
event to invoke any eventual resize related logic. Still bespoke-scale doesn't pick size change, and presentation needs to be brutally reloaded to adjust to new size.Demo of this case: http://medikoo.com/asynchronous-javascript-interfaces/ (press
n
key to toggle notes).This change fixes that.