New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical problems with auth db connections #12

Open

dbnski wants to merge 2 commits into bestpractical:master from dbnski:master

dbnski commented Apr 22, 2016

This pull request resolves two problems:

RT::Handle forces utf8 encoding on the RT database connection, so ExternalAuth::DBI MUST do the same since it does not perform on-the-fly character set conversion. Otherwise RT database may throw errors when non-utf8 characters are present in queries (e.g. accented characters in RealName field), or we may end up writing garbled text into RT tables.
New RT introduced DatabaseExtraDSN, but the module currently does not respect it.

Maciej Dobrzanski added 2 commits

April 22, 2016 12:10


          Respect DatabaseExtraDSN

d8b6317


          RT::Handle implicitly sets UTF8, so we should also request data from …

6d72539

…the external database in UTF8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet