Fix reset options

[haslinghuis]

• Resets the build options when switching flight controller using deep copy
• Do not call FC.resetState() two times a second in portHandler
• Fixes after connecting another FC after a build with local build retaining options:

[netlify]

✅ Deploy Preview for origin-betaflight-app ready!

Name	Link
🔨 Latest commit	3cae1c9
🔍 Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/663915c591914f000800a6d0
😎 Deploy Preview	https://deploy-preview-3932--origin-betaflight-app.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[McGiverGim]

We have an INITIAL_CONFIG that I think does preciselly that:

betaflight-configurator/src/js/fc.js

Lines 5 to 52 in 4d46da2

	const INITIAL_CONFIG = {
	apiVersion: "0.0.0",
	flightControllerIdentifier: '',
	flightControllerVersion: '',
	version: 0,
	buildInfo: '',
	buildKey: '',
	buildOptions: [],
	gitRevision: '',
	multiType: 0,
	msp_version: 0, // not specified using semantic versioning
	capability: 0,
	cycleTime: 0,
	i2cError: 0,
	cpuload: 0,
	cpuTemp: 0,
	activeSensors: 0,
	mode: 0,
	profile: 0,
	uid: [0, 0, 0],
	accelerometerTrims: [0, 0],
	name: '', // present for backwards compatibility before MSP v1.45
	craftName: '',
	displayName: '', // present for backwards compatibility before MSP v1.45
	pilotName: '',
	pidProfileNames: ["", "", "", ""],
	rateProfileNames: ["", "", "", ""],
	numProfiles: 3,
	rateProfile: 0,
	boardType: 0,
	armingDisableCount: 0,
	armingDisableFlags: 0,
	armingDisabled: false,
	runawayTakeoffPreventionDisabled: false,
	boardIdentifier: "",
	boardVersion: 0,
	targetCapabilities: 0,
	targetName: "",
	boardName: "",
	manufacturerId: "",
	signature: [],
	mcuTypeId: 255,
	configurationState: 0,
	configStateFlag: 0,
	sampleRateHz: 0,
	configurationProblems: 0,
	hardwareName: '',
	};

It contains the buildOptions. Why it does not work?

[haslinghuis]

betaflight-configurator/src/js/fc.js

Lines 226 to 229 in 71dad13

	resetState () {
	// Using `Object.assign` instead of reassigning to
	// trigger the updates on the Vue side
	Object.assign(this.CONFIG, INITIAL_CONFIG);

buildOptions is not being reset here. This looks like the root cause. Need further investigation.

[haslinghuis]

@McGiverGim

this.CONFIG.buildOptions is even retained when destroying the object and reassign with INITIAL_CONFIG instead of line 229. With this code this.CONFIG.buildOptions is not retaining previous values when switching FC.

this.CONFIG = null;
this.CONFIG = INITIAL_CONFIG;

[haslinghuis]

@McGiverGim doing a deep copy solves the issue.

https://developer.mozilla.org/en-US/docs/Glossary/Deep_copy

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[McGiverGim]

Not tested, but looks good to me 👌