Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual reboot and auto-connect #3933

Merged
merged 2 commits into from
May 5, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 3, 2024

  • fixes reboot and auto-connect for virtual mode
  • fixes resetting elrsUid for virtual mode

Screenshot from 2024-05-03 13-38-25

@haslinghuis haslinghuis added this to the 11.0 milestone May 3, 2024
@haslinghuis haslinghuis self-assigned this May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 2f551d4
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/663510445972060008763615
😎 Deploy Preview https://deploy-preview-3933--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented May 3, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis requested a review from a team May 3, 2024 18:46
Comment on lines +836 to +845
if (isVirtual) {
return setTimeout(() => {
if (GUI.auto_connect) {
$('a.connect').trigger('click');
}
if (typeof callback === 'function') {
callback();
}
}, 500);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@haslinghuis haslinghuis merged commit 461e2db into betaflight:master May 5, 2024
12 checks passed
@haslinghuis haslinghuis deleted the fix-virtual-reboot branch May 5, 2024 13:16
OGCJM11 pushed a commit to OGCJM11/betaflight-configurator that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants