Update Vue #4258
Update Vue #4258
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
haslinghuis
force-pushed
the
vue3
branch
4 times, most recently
from
5856f0d to
8582462
Compare
haslinghuis
force-pushed
the
vue3
branch
2 times, most recently
from
4e7d763 to
f76d591
Compare
haslinghuis
force-pushed
the
vue3
branch
6 times, most recently
from
9cab0fa to
d7cdf38
Compare
haslinghuis
force-pushed
the
vue3
branch
2 times, most recently
from
69626de to
878857a
Compare
haslinghuis
force-pushed
the
vue3
branch
3 times, most recently
from
5fa885e to
e215b1e
Compare
The biggest problem is with arrays. Vue3 is not detecting well reactivity in some arrays because we have the view and the logic in different files, so we can't access the reactivity proxy in a clean way. I've added reactivity in the definition of the modules affected as a workaround, but I'm sure there must be a better way.
|
|
|
|
@nerdCopter yes there seems to be a difference between local or deployment preview and online version. Added a new PR to improve logging. |
|
I can't reproduce it. If I have the FC connected, and go to https://master.dev.app.betaflight.com/ the FC appears as selected in the combo and if I have autoconnect enabled it connects. |
reset permissions & clear cache then close Chrome. plugin FC. start Chrome/app. |
|
It's difficult to me to reproduce. I've reproduced it only connecting to https://master.dev.app.betaflight.com/ and not always but there I've not too much information. In local I haven't reproduce it. I'm not too sure what this implies. |
Attempting to reconstruct and apply basic migration from 4169 to keep it alive
yarn remove @vitejs/plugin-vue2 yarn remove @panter/vue-i18next yarn remove vue-template-compiler yarn add @vitejs/plugin-vue yarn add vue yarn add tiny-emitter yarn add i18next-vue # yarn add vite --dev yarn add vue-template-compiler --dev yarn add @vue/compiler-sfc --dev // no longer neededIssue is using Vue v3 elements are not updated. Changing options won't reflect for manual, virtual mode. Does not show DFU mode etc. Like the events don't fire or don't reach...
See comment: #4169 (comment)
EDIT: last commit solves the issue with reactive behavior - major thanks to @McGiverGim