Refactor: Enhance WebSerial Class for Improved Readability and Error Handling & Refactor: Modernize and Clean Up Beepers Class

[haybnzz]

Description

Changes Made:

• Beepers Class:

  • Updated to ES6+ syntax (const, let, arrow functions, method shorthand).
  • Replaced self with this for consistency.
  • Simplified array operations using filter and spread operator.
  • Improved DOM manipulation with method chaining.

• WebSerial Class:

  • Enhanced error handling with detailed logging.
  • Refactored into smaller, more focused functions for better organization.
  • Implemented optional chaining to prevent null reference errors.
  • Consistent async/await usage for clearer asynchronous flow control.

Why These Changes Were Necessary:

• To improve code maintainability, readability, and alignment with modern JavaScript practices.
• To enhance robustness and user experience with better feedback on operations.

Potential Impacts:

• No changes in core functionality expected, but testing is crucial to verify behavior:
  • Beepers: Method functionality should remain unchanged.
  • WebSerial: Error handling might behave differently; watch for edge cases.

Testing:

• Both classes have undergone basic testing:
  • Beepers: All methods tested for basic operation.
  • WebSerial: Tested for connectivity and data transfer under normal conditions.
• Comprehensive testing, especially for edge cases and with various devices, is recommended before merging.

Documentation:

• Documentation updates are planned:
  • Beepers: Method descriptions updated for new syntax.
  • WebSerial: New error messages and method structure will be documented.

Future Work:

• Beepers:

  • Add unit tests for each method.

• WebSerial:

  • Enhance error handling for all methods.
  • Revise or add unit tests to cover new refactoring scenarios.

This pull request combines improvements for better code quality, maintainability, and reliability in both the Beepers and WebSerial classes.

[netlify]

❌ Deploy Preview for origin-betaflight-app failed.

Name	Link
🔨 Latest commit	751875b
🔍 Latest deploy log	https://app.netlify.com/sites/origin-betaflight-app/deploys/678ff21736d07d000817cfbc

[github-actions]

Auto-closing pull request because the source branch is named 'master'. Please create a feature branch instead. https://betaflight.com/docs/development#using-git-and-github

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nerdCopter]

just make a new branch from your code to make the PR. git rebase on master if needed.

[nerdCopter]

although the spelling was corrected, the file itself is misspelled: ./src/js/utils/checkBrowserCompatibilty.js

# using https://cli.github.com/
gh pr checkout 4311
git mv ./src/js/utils/checkBrowserCompatibilty.js ./src/js/utils/checkBrowserCompatibility.js
git add -u
git commit -m "checkBrowserCompatibility file rename (spelling)"
git checkout -b haybnzz/enhance_webserial
gh pr create

[nerdCopter]

was able to use ws to pr0p simulator with fixed code.

./websockify 127.0.0.1:6761 127.0.0.1:5761

However, i did have some connection and console errors on actual FC: