-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make backup on flash an option #4360
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4ce022e
to
c3120c2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry need to move default to main.js (as now it adds default in option). |
This comment was marked as outdated.
This comment was marked as outdated.
i don't know that i would keep this option ON. (but also like
|
Perhaps:
Not for now: |
|
220c09d
to
8220ca9
Compare
@nerdCopter think have addressed your review |
ccb7ce9
to
4e4f466
Compare
edit: i think |
This comment was marked as outdated.
This comment was marked as outdated.
@nerdCopter should overwrite once set. Saves for me (changing or refreshing tab in browser) |
This comment was marked as outdated.
This comment was marked as outdated.
Hmmm, works locally but not in preview 🤯 |
This comment was marked as outdated.
This comment was marked as outdated.
edit: in retrospect, i think |
|
Rebased on master |
|
This pull request includes several changes to improve the firmware flashing process and enhance user options. The most important changes include adding new backup options before flashing firmware, modifying the firmware flasher initialization to handle these new options, and updating the user interface to include these options.
Improvements to firmware flashing process:
locales/en/messages.json
:firmwareBackupEnabled
: "Backup enabled"firmwareBackupDisabled
: "Backup disabled"firmwareBackupAsk
: "Ask before backup"firmwareBackupOnFlash
: "Create a backup before flashing new target"Modifications to firmware flasher initialization:
firmware_flasher.initialize
function to include backup options handling:backupOnFlash
configuration and execute appropriate actions [1] [2]Enhancements to user interface:
src/tabs/options.html
:options.js
to initialize the new backup options:options.initBackupOnFlash
function to handle backup configuration [1] [2]These changes ensure that users have more control over the backup process when flashing firmware, enhancing both functionality and user experience.