Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.5 release notes #250

Merged
merged 7 commits into from
Dec 9, 2023

Conversation

ctzsnooze
Copy link
Member

@ctzsnooze ctzsnooze commented Dec 6, 2023

4.5 release notes.

<sorry guys, made a mistake and had to force push - lost your approvals - won't make any more changes to this PR until merged>

No intention whatsoever of omitting people that deserve a mention, please hit me up for all the things I've missed. Suggestions to improve the document can be sent to me over discord or added here.

Click here for a full list of all PR's tagged for the 4.5 milestone. This may include some that were closed before merging, or were not merged.

Copy link
Member

@sugaarK sugaarK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@ctzsnooze ctzsnooze force-pushed the release-notes-draft-for-45 branch from 6ee94af to 247dbac Compare December 6, 2023 02:21
@ctzsnooze ctzsnooze force-pushed the release-notes-draft-for-45 branch from 35bf2d7 to 965cc69 Compare December 6, 2023 05:55
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only have time to check the first paragraphs 😉

docs/release/Betaflight-4.5-Release-Notes.md Outdated Show resolved Hide resolved
docs/release/Betaflight-4.5-Release-Notes.md Outdated Show resolved Hide resolved
@sugaarK sugaarK assigned sugaarK and ctzsnooze and unassigned sugaarK Dec 6, 2023
docs/release/Betaflight-4.5-Release-Notes.md Outdated Show resolved Hide resolved
docs/release/Betaflight-4.5-Release-Notes.md Show resolved Hide resolved

The main benefit is lag reduction on clean builds. Attenuating a notch filter reduces filter-associated lag, which, in turn, can improve propwash. This is an advanced tuning option.

thanks @karatebrot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and @SupaflyFPV, @bw1129 (testing and encouragement)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice :-)

docs/release/Betaflight-4.5-Release-Notes.md Outdated Show resolved Hide resolved
@nerdCopter
Copy link
Member

please click Resolve conversation where applicable.

@nerdCopter
Copy link
Member

nerdCopter commented Dec 7, 2023

Apologies for the minor knit-picky suggests -- i just figured it should be consistent from top to bottom.

@SupaflyFPV
Copy link
Contributor

Apologies for the minor knit-picky suggests -- i just figured it should be consistent from top to bottom.

I have to nitpick you on your spelling of nitpicking.

Just imagine that in the centuries past, picking a tiny insect from another person was regarded as fussy and pedantic.

When it comes to software engineering, its probably better not to leave in the nits, otherwise we may be over-run with bugs.

blckmn
blckmn previously approved these changes Dec 9, 2023
haslinghuis
haslinghuis previously approved these changes Dec 9, 2023
@ctzsnooze ctzsnooze changed the title 45 release notes draft 4.5 release notes Dec 9, 2023
@ctzsnooze ctzsnooze dismissed stale reviews from haslinghuis and blckmn via 191d5fe December 9, 2023 06:12
@ctzsnooze ctzsnooze force-pushed the release-notes-draft-for-45 branch from 191d5fe to e9fb685 Compare December 9, 2023 06:19
@ctzsnooze ctzsnooze requested a review from McGiverGim December 9, 2023 06:19
@ctzsnooze ctzsnooze force-pushed the release-notes-draft-for-45 branch from f13a905 to e9fb685 Compare December 9, 2023 06:56
Copy link

sonarqubecloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use admonitions need to use mdx file extension.

@haslinghuis haslinghuis merged commit 62e5597 into betaflight:master Dec 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants