Add simple stats table #661
Conversation
atomgomba
force-pushed
the
simple-stats
branch
from
124d32c to
4b052f3
Compare
|
screenshot? |
|
atomgomba
force-pushed
the
simple-stats
branch
from
b988a75 to
9168789
Compare
This comment has been minimized.
This comment has been minimized.
atomgomba
force-pushed
the
simple-stats
branch
from
9168789 to
094ed03
Compare
atomgomba
force-pushed
the
simple-stats
branch
from
094ed03 to
94b00a8
Compare
atomgomba
force-pushed
the
simple-stats
branch
from
94b00a8 to
519747f
Compare
This comment has been minimized.
This comment has been minimized.
js/simple-stats.js
Outdated
| .map(chunk => chunk.frames).flatten().value(), | ||
| fields = _.map(flightLog.getMainFieldNames(), (f) => { | ||
| // fix typo. potential bug in either FW or BBE | ||
| if (f == "BaroAlt") { return "baroAlt"; } else { return f; } |
There was a problem hiding this comment.
Please use strict equality https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality
There was a problem hiding this comment.
Thank you for the heads up! I'm going to include request from #309 too 👌
This comment has been minimized.
This comment has been minimized.
|
what are the requirements? may need some error-checking |
|
AUTOMERGE: (FAIL)
|
atomgomba
force-pushed
the
simple-stats
branch
from
308d97d to
d517efc
Compare
|
SonarCloud Quality Gate failed.
|
Good catch! I didn't do testing using logs without GPS data, classic. Pushed the fix, it now should just skip fields with missing data. |
|
Do you want to test this code? Here you have an automated build: |
|
no crashes on many logs. here is sample of 4. approving, but did not investigate actual code. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
| .map(chunk => chunk.frames).flatten().value(), | ||
| fields = _.map(flightLog.getMainFieldNames(), (f) => { | ||
| // fix typo. potential bug in either FW or BBE | ||
| if (f === "BaroAlt") { return "baroAlt"; } else { return f; } |
There was a problem hiding this comment.
Parameter was renamed in betaflight/betaflight#11911
Display a table of extreme values under the values table. Show stats like min/max sticks position, min/max altitude, etc. I'm using this to quickly evaluate the quality of data from test flights.