fixes pylint 2.13.4 issues

betagouv · Mar 31, 2022 · 3959253 · 3959253
1 parent c8edc0c
commit 3959253
Showing 1 changed file with 12 additions and 17 deletions.
diff --git a/lab/admin/mixins.py b/lab/admin/mixins.py
@@ -79,35 +79,30 @@ def has_delete_permission(
             >= self.lab_permissions.delete_permission
         )
 
-    @staticmethod
-    def has_module_permission(request: HttpRequest) -> bool:
+    # pylint: disable=no-self-use
+    def has_module_permission(self, request: HttpRequest) -> bool:
         return request.user.is_staff
 
 
 class LabAdminAllowedMixin:
     """Gives permission to every action to lab admin and restricts others."""
 
-    @staticmethod
-    # pylint: disable=unused-argument
-    def has_module_permission(request: HttpRequest) -> bool:
+    # pylint: disable=unused-argument,no-self-use
+    def has_module_permission(self, request: HttpRequest) -> bool:
         return request.user.is_staff and is_lab_admin(request.user)
 
-    @staticmethod
-    # pylint: disable=unused-argument
-    def has_view_permission(request: HttpRequest, obj: Optional[T] = None):
+    # pylint: disable=unused-argument,no-self-use
+    def has_view_permission(self, request: HttpRequest, obj: Optional[T] = None):
         return request.user.is_staff and is_lab_admin(request.user)
 
-    @staticmethod
-    # pylint: disable=unused-argument
-    def has_add_permission(request: HttpRequest, obj: Optional[T] = None):
+    # pylint: disable=unused-argument,no-self-use
+    def has_add_permission(self, request: HttpRequest, obj: Optional[T] = None):
         return request.user.is_staff and is_lab_admin(request.user)
 
-    @staticmethod
-    # pylint: disable=unused-argument
-    def has_change_permission(request: HttpRequest, obj: Optional[T] = None):
+    # pylint: disable=unused-argument,no-self-use
+    def has_change_permission(self, request: HttpRequest, obj: Optional[T] = None):
         return request.user.is_staff and is_lab_admin(request.user)
 
-    @staticmethod
-    # pylint: disable=unused-argument
-    def has_delete_permission(request: HttpRequest, obj: Optional[T] = None):
+    # pylint: disable=unused-argument,no-self-use
+    def has_delete_permission(self, request: HttpRequest, obj: Optional[T] = None):
         return request.user.is_staff and is_lab_admin(request.user)