Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Modale d'enregistrement des données entreprises (avec CTA) #1243
Feat: Modale d'enregistrement des données entreprises (avec CTA) #1243
Changes from 54 commits
833ea9f
dc4a9b6
0fa860d
334390b
598aaf0
5227a6c
3a8a2ed
759d189
66d9e44
eb57e9e
40bbf62
6ecb801
ea62cb2
94b3fe5
6b29e92
1a797c7
e92baa9
7f408cc
8d91ece
fd11410
5e589c8
bd8ee15
e8c2925
53c8fe7
a035b62
373fc90
3edab65
abb92e4
638e52a
321df59
43cda90
21a6042
b018d0a
35310fa
ed46418
87f94bb
60d21c7
e7fce4c
fb1f2ec
21473ab
c609e17
59d1aa1
ff53e5d
0570c76
dbbb1db
39adb28
73e936f
f698223
d1952d9
9f7ddc5
5a34bee
4287101
8b495f6
3c86f0a
1ea4b5d
e7d8dbd
60070d5
dac4a0e
238a5b8
07afa86
a04b064
c918526
ce7b9d9
431ec41
9cc8d21
c4fb1c9
17f0454
8808efb
1bbef6e
b2923e6
8cd82d1
7f7d509
594a387
8add58a
11ddbef
ff01353
709b7da
541d741
e431bfc
302f80d
a6c329a
53056d7
3e41244
43c951b
04dc740
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question/suggestion: j'imagine que ce style a été défini pour la Transition que tu utilises dans le
TeeRegisterCTA
. C'est volontaire de le déclarer globalement ici plutôt que sur le style scoped du composant (ce qui appliquerait ce style uniquement à la transition du composant plutôt qu'à toutes les transitions de type fade sur l'app)? si non, je le mettrais plutôt dans le style scope du composantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes c'était volontaire je me dis qu'avec l'utilisation du composant Transition c'est plus simple de centraliser les différentes transitions possibles (déjà dans le cas de la transition fade ça va être utilisé aussi par le otherProject)
This file was deleted.