Fix erreur notification AC si adresses mails de la MUS et/ou BSV sont vides #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Le problème initial est que
notify_message(message)
dans la méthodenotify_ac()
raise une exception de typeValidationError - 'recipients: is not a valid email address'
si le mail du contact MUS et/ou BSV est vide.Donc, la sauvegarde du booléen
is_ac_notified
viaself.save()
n'est jamais effectuée.De plus, un objet de type
Message
est créé en base alors qu'il y a eu un problème lors de l'envoi.Pour garantir une cohérence en base des différents objets impliqués :
notify_message(message)
dans un try et sauvegarder le message uniquement si pas d'erreur dans l'envoi de la notifManque le test.