This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Update deployment scripts for three-tier architecture + move to CentOS (WIP) #781
Draft
ronnix
wants to merge
6
commits into
master
Choose a base branch
from
vagrant-fabric-centos
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a343995
to
1bfa4cc
Compare
1bfa4cc
to
009a84a
Compare
009a84a
to
ade3e00
Compare
ade3e00
to
8b5b2d2
Compare
davidbgk
reviewed
Dec 17, 2019
if not is_directory(ctx, "/etc/nginx/snippets"): | ||
create_directory(ctx, "/etc/nginx/snippets", owner="root") | ||
|
||
sudo_put_if_modified(ctx, "files/nginx/ssl.conf", "/etc/nginx/snippets/ssl.conf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line doesn't look to be effective, to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the problem is. I can see the correct file on the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See page 48 of the security audit. Even if the file if present, maybe it is not considered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
→ http --headers https://zam.51.83.111.31.nip.io/
HTTP/1.1 302 Found
Cache-Control: no-store
Connection: keep-alive
Content-Length: 284
Content-Type: text/html; charset=UTF-8
Date: Wed, 18 Dec 2019 23:10:14 GMT
Location: https://zam.51.83.111.31.nip.io/repondeur/identification?source=https%3A%2F%2Fzam.51.83.111.31.nip.io%2Frepondeur%2F
Pragma: no-cache
Server: nginx/1.16.1
→ http --headers https://zam.beta.gouv.fr 2s 164ms
HTTP/1.1 302 Found
Connection: keep-alive
Content-Length: 270
Content-Type: text/html; charset=UTF-8
Date: Wed, 18 Dec 2019 23:10:27 GMT
Location: https://zam.beta.gouv.fr/repondeur/identification?source=https%3A%2F%2Fzam.beta.gouv.fr%2Frepondeur%2F
Server: nginx/1.14.0 (Ubuntu)
Strict-Transport-Security: max-age=15768000; includeSubdomains; preload
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.