This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
Switch from selectize to selectr #867
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
force-pushed
the
selectize-to-selectr
branch
from
585cbf9 to
6a83994
Compare
It definitely introduces a regression given that a search is exact, especially relevant on dossier creation. To be discussed.
davidbgk
force-pushed
the
selectize-to-selectr
branch
from
6a83994 to
475cec6
Compare
davidbgk
commented
Nov 21, 2019
| }, | ||
| includes: function(a, b) { | ||
| // Poor-man fuzzyness. | ||
| return b.split(" ").every(n => a.includes(n)) |
There was a problem hiding this comment.
200 lines of copy-pasta for this single line. There is probably (hopefully?) a better way to monkey patch that.
|
Je repense à nos discussions sur le design de cette page. On pourrait laisser tomber le principe du drop down, lister les dossiers récents, et éventuellement offrir un filtrage fuzzy avec un truc comme https://listjs.com/ |
|
Bonne idée, notre souci en terme d'UX c'est qu'on a 5000 dossiers, on pourrait restreindre aux 100 derniers et offrir une recherche dessus |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It definitely introduces a regression given that a search is exact, especially relevant on dossier creation.
To be discussed.