Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultPlugins should mention that ScheduleRunnerPlugin is not always included #18154

Open
VincentWo opened this issue Mar 4, 2025 · 1 comment
Open

DefaultPlugins should mention that ScheduleRunnerPlugin is not always included #18154

VincentWo opened this issue Mar 4, 2025 · 1 comment
Labels
A-App Bevy apps and plugins C-Docs An addition or correction to our documentation S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@VincentWo
Copy link

On the doc page of DefaultPlugins it is stated that it includes ScheduleRunnerPlugin, but the doc page of ScheduleRunnerPlugin says that it is not included.

Both are kind of correct, kind of wrong: ScheduleRunnerPlugin is currently included in DefaultPlugins if and only if the feature bevy_window is not enabled. I would suggest to clarify this.

I can gladly fix this myself, just wanted to check beforehand because I would have to fiddle a bit with the plugin_group macro :)
@VincentWo VincentWo added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Mar 4, 2025
@alice-i-cecile alice-i-cecile removed the S-Needs-Triage This issue needs to be labelled label Mar 6, 2025
@alice-i-cecile
Copy link
Member

Yep that sounds great!

@alice-i-cecile alice-i-cecile added A-App Bevy apps and plugins S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Docs An addition or correction to our documentation S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alice-i-cecile @VincentWo