Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments and plain text files #1921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sirkcion
Copy link

There are more typos, but restricted myself to only comments and plain text typos as to not break anything on 1st contribution.

@lhog
Copy link
Collaborator

lhog commented Jan 31, 2025

Haha, nice!
Have you used some automated tool to check for typos?

cont/fonts/CREDITS Outdated Show resolved Hide resolved
doc/changelog.txt Outdated Show resolved Hide resolved
@sirkcion
Copy link
Author

Haha, nice! Have you used some automated tool to check for typos?

Used "Typos spell checker" in vscode

@sprunk
Copy link
Collaborator

sprunk commented Jan 31, 2025

I think anything in vendored external libraries rts/lib/* should stay as-is because that makes applying upstream patches more annoying.

@sirkcion
Copy link
Author

Should I be amending my commit or committing on top?

@lhog
Copy link
Collaborator

lhog commented Jan 31, 2025

As you like, we will anyway squash if you have more than 1 commit upon merging or rebase if you have only one commit.

rts/lib/.gitignore Outdated Show resolved Hide resolved
@sirkcion
Copy link
Author

sirkcion commented Feb 7, 2025

I rebased on master, fix conflict, and squashed to single commit.

@sirkcion sirkcion requested review from lhog and sprunk February 7, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants