Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs to explain #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jauggy
Copy link
Member

@jauggy jauggy commented Jan 24, 2025

This will simply add ratings to $explain for split_noobs.

               "Perform brute force with the following players to get the best score.",
               "Players: kyutoryu (9.0), fbots1998 (2.8), jauggy (20.5), Aposis (20.4), [DTG]BamBin0 (20.1), reddragon2010 (18.4), Noody (17.6), SLOPPYGAGGER (8.9), MaTThiuS_82 (8.3), barmalev (3.6)"

The numbers in brackets are their ratings.

I'm trying to understand why the ratings don't add up to team rating in this bug:
https://discord.com/channels/549281623154229250/1332129520538615818

@jauggy jauggy marked this pull request as ready for review January 24, 2025 00:26
@jauggy
Copy link
Member Author

jauggy commented Jan 24, 2025

This code inside balancer_server.ex looks sus:

    team_size =
      teams
      |> Enum.map(fn {_, t} -> Enum.count(t) end)
      |> Enum.max(fn -> 0 end)

Maybe this doesn't calculate the team_size correctly.

Let's say the lobby has 6 players team 1 and 4 players team 2 and then you press balance. I think this would think the team_size is 6 when it should be 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant