Logging improvements #560
Merged
Logging improvements #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of the compilation warning "warn logging level is deprecated"
geekingfrog
force-pushed
the
logging-improvements
branch
2 times, most recently
from
b1ce1c0 to
369ed41
Compare
L-e-x-o-n
requested changes
Jan 24, 2025
https://hexdocs.pm/logger/main/Logger.html#module-backends-and-backwards-compatibility the api for custom logging has changed in elixir 1.15 to instead use the logger_backend project. Also centralise the logging config. Logger definition and base config done at compile time in config/config.exs and runtime or env specific overrides done in config/<env>.exs or config/runtime.exs
With LoggerBackends.Console configured we don't need the default one anymore, which would duplicate all logs sent to the console
We get logs like: 2025-01-24 08:28:16.231 [debug] queue_id=1v1 Player 43 went down, removing from queue 1v1
Don't use `:all` because this logs way too much, things like file, line, erl_level and so on. Maybe later if we go structured log
Not sure if that'a what we want but this keeps the same config as before the logging changes.
Not sure why it's not there. Since the file name don't have date on them, it's better to at least have the date there.
geekingfrog
force-pushed
the
logging-improvements
branch
from
369ed41 to
0853080
Compare
L-e-x-o-n
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements to the logging facilities.
in the console when running the dev version we get things like:
and in the log files we get for example:
I did test that on a release build but it's probably better to have a quick look at how the logs look on the integration server to double check things are all working fine.