Fix/multiple complex property projection #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 7, 2019 10:58
Couldn' get mspec to run so rerouted some test logic to use nunit.
Previous fix also include fix for selecting multiple complex properties produces error with duplicated key (as the name of the property was the complex property instead of some combination of the complex property and its property.
supports basic property with (aggFunc) as (Alias) currently support Sum, Average, Min, Max
but failing to find the correct method with dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed a bug when selecting multiple Complex properties using the Select statement. Problem is it was using the name of the complex class as the name of the property so that the dictionary will have duplicated keys when selecting multiple complex properties. Instead I tried to create a new unique name by combining the ComplexProperty name with the Property of the Complex object.
I also added a "as" syntax so you can pick your own property name in projection. This also works for simple property selection.
I have also attempted implement a very small portion of the aggregation section of the ODATA specification.
This change supports for example "?$apply=aggregate(Age with min as MinAge,Age with sum as TotalAge)")"
Unfortunately I couldn't figure out how to run the MSpec unit tests with VS2017, so instead I wrote my tests with nunit in the same spirit as the MSpec tests.
I am hoping to have "groupby" working, which is what I really wanted to achieve but its quite difficult.
I also updated .Net version to .Net 4.6.2.
Thanks,
Bobby