Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filament-shield.php #334

Closed
wants to merge 1 commit into from

Conversation

EGYWEB-Mohamed
Copy link

isRolePolicyRegistered does not accept an array

image

Copy link

what-the-diff bot commented Feb 12, 2024

PR Summary

  • Change of register_role_policy format
    This update altered the system's settings related to role registration policy. Earlier, it would accept a list of options configured in the system (array format). Now, it has been streamlined to a simple true/false option (boolean format). This modification ultimately makes it easier for users to adjust this setting, enhancing usability and reducing complexity.

Copy link
Owner

@bezhanSalleh bezhanSalleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adjusting the config, could you instead fix the method in the Utils.php instead. that way there won't be any breaking change for others to republish the config again and it will be just a fix.

@bezhanSalleh
Copy link
Owner

Since i'm doing a release and didn't hear from you i went ahead and brought the changes required myself.
Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants