Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove TestSetKeepAlive #1149

Merged
merged 4 commits into from
Mar 13, 2024
Merged

remove TestSetKeepAlive #1149

merged 4 commits into from
Mar 13, 2024

Conversation

cc14514
Copy link
Collaborator

@cc14514 cc14514 commented Mar 12, 2024

  • This unit test uses an external IP for testing.
  • The service at this IP is not stable, and recently, frequent unresponsiveness has resulted in compilation failures.
  • Unit tests should not rely on external services.

@cc14514 cc14514 closed this Mar 13, 2024
@cc14514 cc14514 reopened this Mar 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.24%. Comparing base (1c4a923) to head (9f08d7c).

❗ Current head 9f08d7c differs from pull request most recent head a6b02d1. Consider uploading reports for the commit a6b02d1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1149      +/-   ##
===========================================
- Coverage    54.37%   54.24%   -0.14%     
===========================================
  Files          302      302              
  Lines        26704    26704              
===========================================
- Hits         14520    14485      -35     
- Misses       10520    10565      +45     
+ Partials      1664     1654      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

liangchuan added 4 commits March 13, 2024 10:31
Signed-off-by: liangchuan <[email protected]>
Signed-off-by: liangchuan <[email protected]>
@mileszhang2016 mileszhang2016 merged commit 28d6f4a into bfenetworks:develop Mar 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants