-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcpkg module #245
vcpkg module #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do it this way instead of writing an integration that uses the existing package manager interface? The conan integration, and custom lib modules, standardize on the /<package>//<target>
declarations. This is entirely counter to that. Which makes it impossible for people to move between methods of obtaining libraries without also making changes to their jamfiles.
Please change to support the /<package>//<target>
organization.
I see no way to do it on b2 side. vcpkg doesn't have the concept of generator. It has specific build system "glue" for CMake and MSBuild. For CMake it hijacks |
BTW, to be clear the point of this module is to give a hint to the build system where to search for libraries. This PR grants existing library toolset modules (e.g. zlib, openssl) to search in vcpkg installation trees. I have a separate WIP module that would allow on-the-fly creation of such toolset modules. And that would work along the lines of /package//library convention. |
Here's a rough draft of how to do it:
The result is that users only need to create the |
My approach (with the aforementioned WIP module) will have pretty much the same result, but also
|
Ideally I would prefer to deprecate those built-in modules in favor of package manager methods. Hence...
I would rather just wait for that work :-) |
abf29d2
to
b58bce3
Compare
Having this feature, however implemented, would still be valuable |
But most users don't have a project. They just want to build Boost and have zlib be found. |
This PR has been essentially superceded by #296. I originally intended them to be separate, but in the end decided to put all of this PR's functionality into 296. |
Proposed changes
Adds a module for vcpkg support. The module provides target
/vcpkg//prefix
for manual searching for vcpkg-installed libraries. FIlebuild/ac.jam
also changed to take advantage of vcpkg if it was configured. This will allow existing toolset modules for libraries to gain vcpkg support automatically.Types of changes
Checklist
Further comments
I haven't added any tests. Do I need to in this case?