Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build.bat/bootstrap.bat exit code #371

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Apr 11, 2024

  1. cmd.exe quirk 1: exit /b 1 sets error code 0 for the process, even though it sets errorlevel to 1.
  2. bootstrap.bat needs to check that build.bat succeded (cmd.exe quirk 2: echo off doesn't change errorlevel).
  3. build.bat overrides exit code with call to dir *.exe.
  4. setlocal will rollback pushd on exit (that also helps with Ctrl+C).

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

1. cmd.exe quirk 1: `exit /b 1` sets error code `0` for **the process**, even though it sets `errorlevel` to `1`.
2. `bootstrap.bat` needs to check that `build.bat` succeded (cmd.exe quirk 2: `echo off` doesn't change `errorlevel`).
3. `build.bat` overrides exit code with call to `dir *.exe`.
4. `setlocal` will rollback `pushd` on exit (that also helps with Ctrl+C).
@grafikrobot grafikrobot merged commit 56d0293 into bfgroup:main Apr 21, 2024
142 checks passed
@Kojoley Kojoley deleted the fix-bootstrap.bat-exit-code branch April 22, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants