Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed build for msvc 14.3 with Visual Studio 17.10 or newer #372

Closed
wants to merge 2 commits into from

Conversation

tobias-loew
Copy link

@tobias-loew tobias-loew commented Apr 13, 2024

recognition of msvc toolset v143 for Visual Studio 17.10 or newer did not work

Proposed changes

Checking also for prefix 14.4

Types of changes

Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x] I searched the discussions
  • [ x] I searched the closed and open issues
  • [ x] I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • [ x] I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Tobias Loew and others added 2 commits April 13, 2024 20:44
recognition of msvc toolset v143 for Visual Studio 17.10 or newer did not work
@Nekto89
Copy link

Nekto89 commented May 6, 2024

I've applied this patch on top of b2 4.10.1 and it helped me to build Boost 1.84.0 with VS2022 Update 10 Preview 6 through conan.

@grafikrobot
Copy link
Member

Fixed with 2d756eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants