allow tag feature for virtual-targets with exact name or without type #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tag test fails with this change. Can you look into that? |
|
That's |
|
But thank you for pointing out the Boost PR. I'll have to wait to merge this one until that is resolved. |
grisumbras
force-pushed
the
feature/allow-tag-for-exact
branch
2 times, most recently
from
a1cea49 to
7b91f06
Compare
grafikrobot
force-pushed
the
feature/allow-tag-for-exact
branch
from
7b91f06 to
36cd684
Compare
grafikrobot
force-pushed
the
feature/allow-tag-for-exact
branch
from
9182238 to
d56e361
Compare
I guess the problem is that's not a change that can be applied to older Boost versions. Hence with this b2 change all past Boost versions fail. As can be seen in the tests. |
|
To be honest, I have second thoughts about this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow
<tag>feature to run on virtual targets withexactname or without type.Currently
<tag>is disabled onmaketargets and other targets withexactname or without type. This makes it unnecessary hard to create targets which has name that depends on the property set. I looked at the history of this behaviour, and it seems to be a remnant of not adding type affixes to sucha targets. At one point<tag>handling was added, but the check for having a type and not having anexactname remained.Types of changes
Alternative
Alternative approach is to keep
<tag>disabled when name isexact, and just changemaketargets to not set name toexact.