Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SavingsDaiTokenWrapper address on Ethereum (#6) #300

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

miguelmtzinf
Copy link
Contributor

@miguelmtzinf miguelmtzinf commented Nov 23, 2023

Add SavingsDaiTokenWrapper address on Ethereum, contract to wrap+deposit DAI into sDAI and withdraw+unwrap sDAI in 1 single to transaction, to be used by UI.

* feat: add SavingsDaiTokenWrapper address on Ethereum

* fix: indent issue
@sakulstra
Copy link
Collaborator

We need to do a bit more careful review with this before we'll merge.

Thanks for your patience 🙏

@miguelmtzinf
Copy link
Contributor Author

We applied a fix in the BaseTokenWrapper contract so permit-powered functions are protected against griefing attacks.
Thanks @sakulstra for the review.

@sakulstra sakulstra merged commit ae95dba into bgd-labs:main Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants