Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TubeUp args to be clearer #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orkeilius
Copy link

Hi
The class tubeUp add a default value if output_template is null.

Instead, just set a default value in the function


Also,
I'm trying to refactor the whole project to be easier to maintain and improve by breaking down the tubeUp class into smaller and clearer part
you can see my draft orkeilius/tubeup, I open to feedback.

@orkeilius orkeilius changed the title Refactor TubeuUp args to be clearer Refactor TubeUp args to be clearer Nov 15, 2024
@orkeilius
Copy link
Author

Any update on this ?
Unit test error is caused by #338
And the lint error is in a file I didn't change

@vxbinaca
Copy link
Collaborator

vxbinaca commented Dec 5, 2024

Any update on this ? Unit test error is caused by #338 And the lint error is in a file I didn't change

We had this discussion already. you said we need to either mock youtube, or I said we need to get lucky and the test needs to work.

@vxbinaca
Copy link
Collaborator

vxbinaca commented Dec 5, 2024

If you want unit tests fixed submit a PR, we're volunteers here and I'm not even a programmer.

@orkeilius
Copy link
Author

I'm eventually going to add mocked tests, but I don't know when I'll have the time to do so.

@vxbinaca
Copy link
Collaborator

vxbinaca commented Dec 6, 2024

I'm eventually going to add mocked tests, but I don't know when I'll have the time to do so.

We're all volunteers thanks for your help so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants