Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to allow Deno check to pass and build to succeed. #2161

Closed
wants to merge 29 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
9d18828
add further type checks to catching errors, and then immediately ts-i…
rwblair Oct 14, 2024
cbe29a7
bump github workflows to use deno v2
rwblair Oct 14, 2024
0c4088e
do we really need to specify --node-modules-dir=auto for these deno c…
rwblair Oct 14, 2024
ff37b3a
allow-env during build step.
rwblair Oct 14, 2024
15ebfce
why does installing std library require special permissions?
rwblair Oct 14, 2024
8877ba6
build needs to run git, set --allow-run
rwblair Oct 14, 2024
e6aea46
should of just -A'd it eh?
rwblair Oct 14, 2024
0af7d7e
Update .github/workflows/deno_tests.yml
effigies Oct 15, 2024
a174a76
specify default import from ajv in validators/json.ts imports
rwblair Oct 15, 2024
d941cf6
Merge branch 'fix/deno_2_test_and_build' of github.com:rwblair/bids-v…
rwblair Oct 15, 2024
b67e28f
revert ajv import bump version. Deno may be installing from package.j…
rwblair Oct 15, 2024
dde7007
bump ajv in package.json. Will this break legacy?
rwblair Oct 15, 2024
0b88900
Revert "bump ajv in package.json. Will this break legacy?"
rwblair Oct 15, 2024
fd86b31
move legacy validator to its own directory.
rwblair Oct 15, 2024
3ac00ad
working-dir -> working-directory
rwblair Oct 15, 2024
3331f80
more working-directory setting. fix sym link from legacy test to curr…
rwblair Oct 15, 2024
d3258d2
more working-directory setting. fix sym link from legacy test to curr…
rwblair Oct 15, 2024
c9ed50c
in progress README updates
rwblair Oct 15, 2024
064fea7
Merge branch 'master' of github.com:bids-standard/bids-validator into…
rwblair Oct 17, 2024
c87f70c
set working directory for circleci
rwblair Oct 17, 2024
e9e919c
Merge branch 'fix/deno_2_test_and_build' of github.com:rwblair/bids-v…
rwblair Oct 17, 2024
10044b7
deno loader back to version 11
rwblair Oct 17, 2024
efbbc77
amend circle cache paths, they may not respect working-directory
rwblair Oct 17, 2024
bc6afbb
working-directory -> working_directory
rwblair Oct 17, 2024
8f4fd8f
fix call to get local version
rwblair Oct 17, 2024
25c4bb3
remove circleci config
rwblair Oct 17, 2024
0c3f8a8
first pass at deno dockerfile. Update docker github workflow accordin…
rwblair Oct 21, 2024
5f75b1e
Revert "remove circleci config"
rwblair Oct 21, 2024
6923b6f
Move dockerfile to base. Deno cli now handles git not existing.
rwblair Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix call to get local version
  • Loading branch information
rwblair committed Oct 17, 2024
commit 8f4fd8f7608c0a62e79a98b4adde4c65fbbe97dd
2 changes: 1 addition & 1 deletion bids-validator/src/version.ts
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ export async function getVersion(): Promise<string> {
async function getLocalVersion(path: string): Promise<string> {
// safe.directory setting so we could still operate from another user
const command = new Deno.Command("git", {
args: ['git', '-C', path, '-c', 'safe.directory=*', 'describe', '--tags', '--always'],
args: ['-C', path, '-c', 'safe.directory=*', 'describe', '--tags', '--always'],
})
rwblair marked this conversation as resolved.
Show resolved Hide resolved
const { success, stdout } = await command.output();
const description = new TextDecoder().decode(stdout).trim()